Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Php 7 Upgrade #20

Merged
merged 35 commits into from Aug 6, 2018
Merged

Php 7 Upgrade #20

merged 35 commits into from Aug 6, 2018

Conversation

Sephster
Copy link
Collaborator

Upgrade WebPA code so it can run on PHP 7

@Sephster
Copy link
Collaborator Author

I will leave this up for a day or two before merging into the newly created v3 branch.

I've tested this and successfully logged in on a PHP 7.1 server. There is an outstanding issue for PHP version 7.2 as the code uses create_function which I believe was deprecated for PHP 7.2 but it is a tricky fix.

I will create an issue to fix this separately.

Also, there was a bug fix added in develop which I have had to revert as it was preventing admins from logging in. I believe it will reintroduce whichever bug this was trying to fix but without admin login, fresh installs are very difficult to get off the ground without dev knowledge. Again, I will raise an issue to fix this bug properly at a later date.

@Sephster
Copy link
Collaborator Author

I removed the function causing issues with PHP 7.2 as I realised it wasn't being called by anything. This branch should be ready for release now. No one has raised issues since I announced this and my own testing raised no issues. I will do some final testing shortly but if there are no bugs I can find, I think this should be released as version 3

@rcraggs
Copy link
Collaborator

rcraggs commented Jul 10, 2018

Thanks for your work on this

@Sephster Sephster merged commit d53b388 into WebPA:3.0.0 Aug 6, 2018
@Sephster Sephster deleted the php7-upgrade branch August 6, 2018 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants